This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][TUPLES] Fix for a number of ICE's in g++ regression test.
- From: "Andrew Pinski" <pinskia at gmail dot com>
- To: "Doug Kwan (éæå)" <dougkwan at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "Diego Novillo" <dnovillo at google dot com>
- Date: Fri, 9 May 2008 16:27:09 -0700
- Subject: Re: [PATCH][TUPLES] Fix for a number of ICE's in g++ regression test.
- References: <498552560805091623w5afd6e2eld7f44fa511b574bb@mail.gmail.com>
On Fri, May 9, 2008 at 4:23 PM, Doug Kwan (éæå) <dougkwan@google.com> wrote:
> Hi Diego,
>
> Can you review this? That's all there is for this week :)
> + /* See through pointer or reference to functions. */
> + if (TREE_CODE (type) == POINTER_TYPE || TREE_CODE (type) == REFERENCE_TYPE)
Use:
if (POINTER_TYPE_P (type))
Instead and just say pointer.
> + /* Sometimes the C++ front-end generates a POINTER_PLUS_EXPR whose
> + operand 0 has type not trivailly convertible to the expression
> + type. We need to do a conversion. */
I would fix the C++ front-end instead to produce the correct type.
Thanks,
Andrew Pinski