This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch]: PR/36180

From: "Richard Guenther" <richard dot guenther at gmail dot com>
To: "Kai Tietz" <Kai dot Tietz at onevision dot com>
Cc: "Dominique Dhumieres" <dominiq at lps dot ens dot fr>, gcc-patches at gcc dot gnu dot org
Date: Thu, 8 May 2008 13:58:09 +0200
Subject: Re: [patch]: PR/36180
References: <20080508102831.304C33BE9C@mailhost.lps.ens.fr> <OFD74567B3.6A681BDE-ONC1257443.003C6BCC-C1257443.003D1232@onevision.de> <84fc9c000805080427q72bf0981w774a7fde5c17f708@mail.gmail.com>

On Thu, May 8, 2008 at 1:27 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Thu, May 8, 2008 at 1:07 PM, Kai Tietz <Kai.Tietz@onevision.com> wrote:
>  > Hello,
>  >
>  >  This patch fixed PR/36180 reasoned by the introduction of
>  >  TARGET_RETURN_IN_MEMORY in i386.
>  >
>  >  Dominique: Could you test the attached patch?
>  >
>  >  ChangeLog
>  >
>  >  2008-05-08  Kai Tietz  <kai.tietz@onevision.com>
>  >
>  >         * calls.c (compute_argument_block_size ): Add ATTRIBUTE_UNUSED to
>  >         fndecl argument.
>  >         (emit_library_call_value_1): Add ATTRIBUTE_UNUSED to variable
>  >         fndecl.
>  >         * target-def.h: Check that TARGET_RETURN_IN_MEMORY isn't declared
>  >  in front.
>  >
>  >  Is this patch ok for apply?
>
>  This is ok.

Did you test these patches properly?  I now run into

../../trunk/gcc/config/i386/i386.c:25721: error: initialization from
incompatible pointer type

Richard.

Follow-Ups:
- Re: [patch]: PR/36180
  - From: Richard Guenther

References:
- [patch]: PR/36180
  - From: Kai Tietz
- Re: [patch]: PR/36180
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]