This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH 01: Testsuite: compare outputs of a testcase compiled and run with 2 flags


On Thu, 2008-05-01 at 13:47 -0500, Jagasia, Harsha wrote:
> Hi,
>
> Sorry, I forgot to add the below:
>
> This patch is intended to be used for graphite when it gets merged with
> mainline.

This is not entirely true: the patch has nothing to do with graphite,
and can be used for any code transform.  In particular, we will use
this functionality with graphite flags for random combinations of loop
transforms.

On Thu, May 1, 2008 at 5:55 PM, Janis Johnson <janis187@us.ibm.com> wrote:
>  I don't understand the point of the new functionality.  Why isn't
>  it sufficient to just run the entire testsuite with -fgraphite,
>  specified as part of RUNTESTFLAGS?  Each test already checks for
>  its expected result, whatever that might be, and many tests are
>  already run with multiple sets of options.

The patch from Harsha checks that the observational semantics is
preserved after a transform: it checks that the outputs of the program
are the same with and without a flag.  Compiling the entire testsuite
with and without a flag is not enough and too long: there are too many
irrelevant testcases, some not containing loops, and others that have
no checks for their outputs.  Furthermore there is no way to ask
people to test more than once all the testsuite with different flags.

-- 
Sebastian Pop
AMD - GNU Tools


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]