Re: [patch i386]: Fix output_emit_asm in output_set_got for x86_64.

[Kai Tietz <Kai dot Tietz at onevision dot com>]

"Uros Bizjak" <ubizjak@gmail.com> wrote on 05.05.2008 13:31:51:

> Hello!
> 
> > 2008-05-05  Kai Tietz  <kai.tietz@onevision.com>
> 
> >        * config/i386/i386.c (output_set_got): Fix for x86_64 
> output_emit_asm
> >        by using 'q' specifier for instruction.
> 
> > Is this patch ok for apply?
> 
> This is OK for mainline.
> 
> BTW: There is also one in ix86_file_end function, used for
> USE_HIDDEN_LINKONCE targets (AFAICT - cygwin and darwin). Can you
> please check if TARGET_64BIT_MS_ABI is correct condition, or we want
> TARGET_64BIT here)? This will affect also darwin, so the maintainer is
> CC'd.
> 
> Thanks,
> Uros.

The new patch including the ix86_file_end change.

2008-05-05  Kai Tietz  <kai.tietz@onevision.com>

        * config/i386/i386.c (output_set_got): Fix for x86_64 
output_emit_asm
        by using 'q' specifier for instruction.
        (ix86_file_end): Replaced case TARGET_64BIT_MS_ABI by 
TARGET_64BIT.

Is this patch ok for apply?

  Kai



|  (\_/)  This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.

Attachment: x86_64_asm_insn.txt
Description: Text document