This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [fortran,patch] Add SELECTED_CHAR_KIND intrinsic
- From: FX <fxcoudert at gmail dot com>
- To: Tobias Burnus <tobias dot burnus at physik dot fu-berlin dot de>
- Cc: gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Wed, 30 Apr 2008 23:41:18 +0100
- Subject: Re: [fortran,patch] Add SELECTED_CHAR_KIND intrinsic
- References: <20080430201933.GA2505@physik.fu-berlin.de>
The patch is OK, however, it took me a while to correctly read:
+ len = (alen > blen) ? alen : blen;
I somehow read: len = MIN(alen,blen) instead of MAX(...)
I therefore wonder whether one should add a comment somewhere.
Or I can make it len = MAX(alen, blen). (MAX is defined as a macro in
gcc/system.h) That's what I committed.
Regtesting on x86_64-linux showed that I had once again forgotten to
add the new symbol to gfortran.map, so I committed with the following
chunk added:
--- trunk/libgfortran/gfortran.map 2008/04/30 21:42:24 134838
+++ trunk/libgfortran/gfortran.map 2008/04/30 21:45:02 134839
@@ -1037,6 +1037,7 @@
_gfortran_erfc_scaled_r8;
_gfortran_erfc_scaled_r10;
_gfortran_erfc_scaled_r16;
+ _gfortran_selected_char_kind;
_gfortran_st_wait;
} GFORTRAN_1.0;
Thanks Tobias for the very quick review!
FX
--
François-Xavier Coudert
http://www.homepages.ucl.ac.uk/~uccafco/