Re: [patch testsuite]: gcc.dg/large-size-array-2.c and larget-array-4.c

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Wed, Apr 30, 2008 at 10:55 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
> Hi HJ,
>
>  it seems that you fix inverted the intention of my initial patch.
>  The check for this warning should be done for target x86_64-*-mingw*,
                                           ^^^^^^^^^^^^^^^^
>  but as you wrote
>  ...
>  /* { dg-error "too large" "" { target { { ! lp64 } || x86_64-*-mingw*
>  } }  6 } */
>  ...
>  it checks it always for this target :)

My patch expects an error for x86_64-*-mingw*.  Did you mean that
there this warning should NOT be done for target x86_64-*-mingw*?
If it is true,  you should replace || with &&.

>
>  Something like
>  /* { dg-error "too large" "" { target { { ! lp64 }  { !
>  x86_64-*-mingw* } } }  6 } */
>
>  would be more correct. I am uncertain if the shoud be a && between,
>  but as far as I remember it is not necessary.

I think that is the exact bug my patch fixed.

H.J.
>  Cheers,
>   Kai
>  --
>  | (\_/) This is Bunny. Copy and paste
>  | (='.'=) Bunny into your signature to help
>  | (")_(") him gain world domination
>