This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [tuples] [patch] make gimple-pretty-print closer to tree-pretty-print

From: Diego Novillo <dnovillo at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 29 Apr 2008 12:51:55 -0400
Subject: Re: [tuples] [patch] make gimple-pretty-print closer to tree-pretty-print
References: <38a0d8450804290722w67bb683cv2fe4c388f2de5776@mail.gmail.com>

On 4/29/08 10:22 AM, Rafael Espindola wrote:

* gimple-pretty-print.c (dump_gimple_assign): print ";" at the end.
(dump_gimple_return):print ";" at the end.
(dump_gimple_call): print ";" at the end.
(dump_gimple_cond): use op_symbol_code instead of tree_code_name.
(pp_cfg_jump): print ";" at the end.

OK for tuples?

Given that Richard had a good point regarding cut-n-paste, I think it's best if we continue using semicolons. The dumps need to be useful, after all.

So, the patch is OK. Call pp_semicolon(), though.

Diego.

References:
- [tuples] [patch] make gimple-pretty-print closer to tree-pretty-print
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]