This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH,SH] 64-bit integer comparison is incorrect

Christian BRUEL <christian.bruel@st.com> wrote:
> here it is.

Although I'm not sure if it's mandatory for testcases, it's
better to follow the coding standard, isn't it?
If so, the comment at the top would be formatted like as

/* Problem only noticed on SH for -mcbranchdi DImode comparison with
   constants.  Target dependant failure but test valid for alls.  */

and spaces are needed between the function symbol and '('.
Also I guess that using abort is the usual way when multiple
tests are done in main:

extern void abort (void);

int main ()
{
  if (test2n (-1LL))
    abort ();

  if (test2n (-2LL))
    abort ();
  ...

Regards,
	kaz
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]