This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][TUPLES] Fix for gcc.dg/conv-2.c failures.
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: "Doug Kwan (?????w)" <dougkwan at google dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 14 Apr 2008 18:05:53 -0400
- Subject: Re: [PATCH][TUPLES] Fix for gcc.dg/conv-2.c failures.
- References: <498552560804141438l20f5caa7y81fe382c16509979@mail.gmail.com>
On Mon, Apr 14, 2008 at 02:38:20PM -0700, Doug Kwan (?????w) wrote:
> Hi Aldy,
>
> Could you review this? For some reason, this is different from
> the trunk and it causes 30+ failing tests.
That's odd. I seem to have brought that in with this merge:
+ Merged revisions 124007-125166 from mainline.
I wonder why subsequent merges didn't bring in a more recent copy.
Oh well. Yes, that's fine.
Thanks.
>
> -Doug
>
> 2008-04-14 Doug Kwan <dougkwan@google.com>
>
> * c-typeck.c (convert_for_assignment): Call c_common_unsigned_type
>
> Index: gcc/gcc/c-typeck.c
> ===================================================================
> --- gcc/gcc/c-typeck.c (revision 134253)
> +++ gcc/gcc/c-typeck.c (working copy)
> @@ -4253,8 +4253,8 @@ convert_for_assignment (tree type, tree
> if (VOID_TYPE_P (ttl) || VOID_TYPE_P (ttr)
> || (target_cmp = comp_target_types (type, rhstype))
> || is_opaque_pointer
> - || (unsigned_type_for (mvl)
> - == unsigned_type_for (mvr)))
> + || (c_common_unsigned_type (mvl)
> + == c_common_unsigned_type (mvr)))
> {
> if (pedantic
> && ((VOID_TYPE_P (ttl) && TREE_CODE (ttr) == FUNCTION_TYPE)