This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][TUPLES] Tuplification of ipa-pure-const.c
Thanks. Will update patch per suggestions, rebuild, retest and submit.
-Doug
2008/4/11 Diego Novillo <dnovillo@google.com>:
> On Thu, Apr 10, 2008 at 22:08, Doug Kwan (Ãö®¶¼w) <dougkwan@google.com> wrote:
>
> > * ipa-pure-const.c (get_asm_expr_operands): Tuplify.
> > (get_asm_expr_operands): Tuplify.
> > (check_call): Tuplify. Add code to handle return value assignment.
> > (scan_function): Remove. Original code is tuplified and split into
> > two new functions scan_function_op and scan_function_stmt.
> > (scan_function_op): New function.
> > (scan_function_stmt): New function.
> > (analyze_function): Tuplify and re-enable previously disabled code.
> > * passes.c (init_optimization_passes): Re-enable pass_ipa_pure_const.
>
> OK with
>
> > - for (i=0, link = ASM_OUTPUTS (stmt); link; ++i, link = TREE_CHAIN (link))
> > + for (i=0; i < noutputs; i++)
>
> s/i=0/i = 0/
>
> > -scan_function (tree *tp,
> > - int *walk_subtrees,
> > - void *data)
> > +scan_function_op (tree *tp,
> > + int *walk_subtrees,
> > + void *data)
>
> These arguments can all go in the same line.
>
> > {
> > - struct cgraph_node *fn = (struct cgraph_node *) data;
> > + struct walk_stmt_info *wi = (struct walk_stmt_info *) data;
>
> No need to do this anymore. walk_gimple_stmt callbacks now take
> struct walk_stmt_info * as their last argument (this was changed
> after your patch).
>