Vladimir Makarov <vmakarov@redhat.com> wrote on 04/04/2008 02:20:15 PM:
I tried your patch on ppc64 (a Power6 box). For the most part results
were
close, but 187.facerec degraded about 24% with -fira. It looks like
the
hot procedure, graphRoutines.f90:LocalMove(), ended up with a lot more
spill code.
Thanks for testing.
I know about the problem, it was occurred as the result of latest
patches. IRA by mistake assigns FLOAT_REGS instead of GENERAL_REGS
for some pseudos. The wrong code results in code size degradation too
on ppc64 and itanium.
I have the patch for fixing this. I'll commit it to the branch today.
I've just committed a patch fixing the problem. Sorry for
inconvenience. I've should done it earlier.
I tried the latest ira branch which includes your fix, but am still seeing
the degradation, still due to extra spill in the mentioned procedure.
Following are static instruction counts from the annotated oprofile report
for LocalMove(), both stack references and LR/CTR moves (which can also be
used for spill). Granted not all these references are for spill, but gives
a general feel of increase.
Old/existing RA:
run/00000014> grep "(r1)" oprof.localmove.annot | wc -l
393
run/00000014> grep mflr oprof.localmove.annot | wc -l
1
run/00000014> grep mfctr oprof.localmove.annot | wc -l
0
run/00000014> grep mtlr oprof.localmove.annot | wc -l
1
run/00000014> grep mtctr oprof.localmove.annot | wc -l
2
-fira:
run/00000016> grep "(r1)" oprof.localmove.annot | wc -l
686
run/00000016> grep mflr oprof.localmove.annot | wc -l
69
run/00000016> grep mfctr oprof.localmove.annot | wc -l
61
run/00000016> grep mtlr oprof.localmove.annot | wc -l
51
run/00000016> grep mtctr oprof.localmove.annot | wc -l
46