This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH,updated] PR35371 GCSE loses track of REG_POINTER attribute
- From: Peter Bergner <bergner at vnet dot ibm dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Richard Sandiford <rsandifo at nildram dot co dot uk>, Jeff Law <law at redhat dot com>, "H.J. Lu" <hjl dot tools at gmail dot com>
- Date: Mon, 07 Apr 2008 12:42:05 -0500
- Subject: Re: [PATCH,updated] PR35371 GCSE loses track of REG_POINTER attribute
- References: <20080331225840.GA30393@vervain.rchland.ibm.com> <200804050936.43498.ebotcazou@adacore.com>
On Sat, 2008-04-05 at 09:36 +0200, Eric Botcazou wrote:
> > This has bootstrapped and regtested with no errors on powerpc64-linux and
> > H.J. kindly SPEC tested this on x86_64 and saw no performance regressions.
> > Is this ok for mainline?
>
> It's OK if you find a better name for gen_reg_rtx_copy: the bare "copy"
> clearly suggests that it will copy the value of the source. Something like
> gen_reg_rtx_and_attrs for example but Richard may have a better idea.
Actually, Richard and I both tried copping out which is how we ended up
with the lame name I came up with. So your suggestion wins! :)
I checked in the patch using your gcc_reg_rtx_and_attrs suggestion.
If you change your mind, let me know and I'll change it.
This is now on trunk as revision 133985. Thanks!
Peter