This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: cleanup for conversion exprs code patterns (1/16)


Hi, 

> 
> NON_LVALUE_EXPRs should be removed without adding them
> to such grouping scheme first.  I suggest you patch tree-cfg.c:verify_expr
> to handle it like
> 
>   NON_LVALUE_EXPR:
>      gcc_unreachable ();
> 
> as they shouldn't survive until the middle-end IL (and thus handling for
> it can be safely removed from all places once the verify_expr patch
> bootstraps & tests cleanly).  But please separate NON_LVALUE_EXPR
> handling out into a separate patch(-series).

I am not completely sure there. You mean remove only uses of
NON_LVALUE_EXPRs where is not possibility to reach expr as
NON_LVALUE_EXPR or completely remove NON_LVALUE_EXPRs thru whole gcc
(mainly in frontends) ?

Greetings 
Tomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]