This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran]PR25829 Add support for F2003 I/O features


On Sat, 2008-04-05 at 13:32 +0200, Tobias Burnus wrote:
> Hi Jerry,
> 
> > The patch is getting too big so i do not want to add any more until we
> > get this in trunk,
> > With that said, I have attached the latest patch and 7 new test cases.
> > OK for trunk.
> 
> I think the patch is OK.
> 
> I added some more items below, but they can be fixed later.
> (a), (b) and (c) are relatively simply, (d) needs more effort.
> And (e) can be postponed or included in the (a) to (c) patch.
> 
Yes all of these of course.  Most should be straight forward at this
point.  It takes some tedium to do.  An example to watch out for is the
sign status mechanism.  There are two different enumerators being used.
The original is embedded in the dtp structure. The other is unit_sign in
io.h. The unit_sign is the way to go, however, if it is not ordered
correctly, things break. (I will add that it took some time to figure
that out) Fixing this is on my list.

I plan to commit the patch after the following:

1) clean up ChangeLogs
2) Version the st_wait symbol
3) Cross test the libraries with 4.3

After the commit, I will start on the items identified by Tobias.

Thanks for review and test case examples.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]