This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] new driver level option -wrapper for developer convenience.


>>>>> ">" == "Seongbae Park (ëìë, ææå)" <seongbae.park@gmail.com> writes:

>> This patch adds a new option -wrapper for the convenience of the
>> developers.  This option can be used to invoke all subcommands of
>> gcc under gdb or any profiling/debugging programs easily.

I think this would be pretty useful.

>> Apparently I wrote that patch before I got used to GNU style.
>> Here's the updated patch (with hopefully no style errors).

Looks pretty good.  I can't approve it but it seems ok to me.

I saw a couple little nits ...

>> +  while((p = strchr(p, ',')) != NULL);

There are a couple missing spaces here, after the while and the
strchr.  This occurs in the other do-while as well.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]