This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Detect L2 cache size for x86


On Fri, Apr 4, 2008 at 7:28 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> Your ChangeLog entry doesn't document what you changed. Can you rename
>  decode_l2_caches_amd to decode_l2_caches since it isn't AMD specific?

Committed [1] with requested changes and following ChangeLog entry:

2008-04-04  Zuxy Meng <zuxy.meng@gmail.com>

	* config/i386/driver-i386.c (describe_cache): Add l2_sizekb argument.
	Pass L2 size as "--param l2-cache-size" to the compiler.
	(decode_l2_cache): New function to decode L2 cache parameters using
	0x8000006 extended cpuid function.
	(detect_caches_amd): Determine parameters of L2 cache using
	decode_l2_caches function.
	(decode_caches_intel): Decode L2 cache parameters.
	(detect_caches_intel): Determine L2 cache parameters using
	decode_caches_intel and decode_l2_caches functions.


[1] http://gcc.gnu.org/viewcvs?view=rev&revision=133890

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]