This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.
- From: Ralf Wildenhues <Ralf dot Wildenhues at gmx dot de>
- To: Seongbae Park (ëìë, ææå) <seongbae dot park at gmail dot com>
- Cc: Jan Hubicka <jh at suse dot cz>, Jan Hubicka <hubicka at ucw dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 2 Apr 2008 00:50:06 +0200
- Subject: Re: [PATCH] profile feedback: -fprofile-use= and -fprofile-correction, correctness fixes and option semantic changes.
- References: <ab3a61990803201358l2da959c0t166e9bdfba53dd09@mail.gmail.com> <20080327002102.GA19577@atrey.karlin.mff.cuni.cz> <ab3a61990803261743o23ac57e7h68ddbbcf36aa5853@mail.gmail.com> <20080327085203.GE9479@kam.mff.cuni.cz> <ab3a61990803271616u6b69f7fbv2ebc9fb5283c9c18@mail.gmail.com> <20080329225710.GI9479@kam.mff.cuni.cz> <ab3a61990803311453x43333792i2572e761a95680b7@mail.gmail.com>
Hello Seongbae,
* Seongbae Park (ëìë, ææå) wrote on Mon, Mar 31, 2008 at 11:53:36PM CEST:
> The patch updated per comment has been applied to the mainline as
> revision 133774.
[...]
> ChangeLog
> 2008-03-31 Seongbae Park <seongbae.park@gmail.com>
>
> * Makefile.tpl (.NOTPARALLEL): Serialize stageprofile libiberty.
> * Makefile.in (.NOTPARALLEL): Regenerate.
> +.NOTPARALLEL: all-stageprofile-libiberty
> +
Not sure if you're aware of it, but with current GNU make, listing
prerequisites to .NOTPARALLEL doesn't have any effect; the above will
simply cause 'make' not to run any rules in this Makefile in parallel.
Since this hurts parallel build performance, can't we formulate the
required ordering in terms or order-only dependencies? Something like
all-stageprofile-libiberty: | $(targets_that_need_to_run_earlier)
$(targets_that_need_to_run_later): | all-stageprofile-libiberty
You may have to check that this doesn't expose the make bug, though:
<http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html>.
Thanks,
Ralf