This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [tuples] [patch] Fix in_phi in verify_expr

From: "Diego Novillo" <dnovillo at google dot com>
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: "Rafael Espindola" <espindola at google dot com>, GCC <gcc-patches at gcc dot gnu dot org>
Date: Tue, 1 Apr 2008 11:28:53 -0400
Subject: Re: [tuples] [patch] Fix in_phi in verify_expr
References: <38a0d8450804010708ib7903dfw386d2ade4e424dcb@mail.gmail.com> <84fc9c000804010720q5dcef4a3xf98874c57c234093@mail.gmail.com> <38a0d8450804010739j6ad2c604n52a715ec1f242aa1@mail.gmail.com> <b798aad50804010746h788febb0pd04626863cce898@mail.gmail.com> <84fc9c000804010755x77c4f198i9cf9fabf35a0c672@mail.gmail.com> <38a0d8450804010813w4de0b6f6od9fa83acbb4d3ff4@mail.gmail.com> <84fc9c000804010817m77687104k2fb3af53c5977bc7@mail.gmail.com> <38a0d8450804010819k106ece72j1bfaa2f7df93e083@mail.gmail.com> <b798aad50804010821u519bb8fdn8619cb41284ed6de@mail.gmail.com> <84fc9c000804010825y8aa7746u19ff6696d21fd00e@mail.gmail.com>

On Tue, Apr 1, 2008 at 11:25, Richard Guenther
<richard.guenther@gmail.com> wrote:

>  But a general ADDR_EXPR is not a valid PHI argument.

What about &WEAK_GLOBAL?  That's the only one that is nagging me.

>
>  Btw, I was suggesting the following in place of your verify_stmts parts:

This is exactly the patch that Rafael proposed.

Diego.

Follow-Ups:
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Richard Guenther

References:
- [tuples] [patch] Fix in_phi in verify_expr
  - From: Rafael Espindola
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Richard Guenther
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Rafael Espindola
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Diego Novillo
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Richard Guenther
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Rafael Espindola
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Richard Guenther
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Rafael Espindola
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Diego Novillo
- Re: [tuples] [patch] Fix in_phi in verify_expr
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]