This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix pch failures when opening a header that has been precompiled multiple times (PR pch/13675)
- From: Tom Tromey <tromey at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Geoffrey Keating <geoffk at geoffk dot org>, gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Mar 2008 12:06:15 -0600
- Subject: Re: [PATCH] Fix pch failures when opening a header that has been precompiled multiple times (PR pch/13675)
- References: <20080331141010.GK30807@devserv.devel.redhat.com>
- Reply-to: Tom Tromey <tromey at redhat dot com>
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Jakub> The fix below clears pch (and frees pchname) once the *.gch
Jakub> file is read using cb.read_pch, which means that an include
Jakub> file won't be handled as a PCH file in the second and following
Jakub> #include (which matches the PCH design).
Jakub> This patch also removes unnecessary field from struct _cpp_file
Jakub> (file->pch is true iff file->pchname != NULL) and fixes a
Jakub> double close bug
This looks good to me.
I don't think I can approve the c-pch.c part.
If you want to check in the deletion of the field in libcpp
separately, that would be fine by me. But, waiting for full approval
is also ok.
Tom