This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH COMMITTED: Let -frepo look for symbol name in single quotes
- From: Ian Lance Taylor <iant at google dot com>
- To: tromey at redhat dot com
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Mar 2008 11:41:25 -0700
- Subject: Re: PATCH COMMITTED: Let -frepo look for symbol name in single quotes
- References: <m3myoepy6w.fsf@google.com> <m3abke6c5y.fsf@fleche.redhat.com>
Tom Tromey <tromey@redhat.com> writes:
>>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:
>
> Ian> So, I committed this patch to let -frepo look for single quotes.
> Ian> /* Then try "double quotes". */
> Ian> else if (p = strchr (oldq, '"'), p)
> Ian> p++, q = strchr (p, '"');
> Ian> + /* Then try "single quotes". */
> Ian> + else if (p = strchr (oldq, '\''), p)
> Ian> + p++, q = strchr (p, '\'');
>
> Here's a small nit for you -- I think the style in the comments here
> is supposed to reflect the style of the matched text... hence:
>
> /* First try `GNU style'. */
> /* Then try "double quotes". */
>
> So I think this ought to read /* Then try 'single quotes'. */
>
> I think this detail is so small and obscure that I should qualify for
> a prize.
Whoops, I actually sent the wrong version of the patch! I did in fact
get it right in the actual committed code. Sorry about that, and
thanks for pointing it out. As you know, nothing is too small or
obscure.
Ian