This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: cleanup for conversion exprs code patterns (1/16)
- From: Tom Tromey <tromey at redhat dot com>
- To: tomby at atrey dot karlin dot mff dot cuni dot cz (Tomas Bily)
- Cc: gcc-patches at gcc dot gnu dot org, tomby at ucw dot cz, tbily at suse dot cz
- Date: Mon, 31 Mar 2008 11:26:02 -0600
- Subject: Re: [PATCH]: cleanup for conversion exprs code patterns (1/16)
- References: <20080331144912.C402CF00AB@atrey.karlin.mff.cuni.cz>
- Reply-to: tromey at redhat dot com
>>>>> "Tomas" == Tomas Bily <tomby@atrey.karlin.mff.cuni.cz> writes:
Tomas> There is a lot of duplicate code patterns for conversion
Tomas> expressions (CONVERT_EXPR, NOP_EXPR, NON_LVALUE_EXPR) that can
Tomas> be substituted by macro.
Did you consider just getting rid of the duplication?
IMO, we only really need CONVERT_EXPR and VIEW_CONVERT_EXPR -- i.e., a
cast operator and a "change the interpretation" operator. I think all
the other operations are redundant given that we also carry type
information. (Well, except NON_LVALUE_EXPR, which should be removed
but which is a different kind of problem.)
Tom