This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH COMMITTED: Let -frepo look for symbol name in single quotes
- From: Tom Tromey <tromey at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Mar 2008 11:22:49 -0600
- Subject: Re: PATCH COMMITTED: Let -frepo look for symbol name in single quotes
- References: <m3myoepy6w.fsf@google.com>
- Reply-to: tromey at redhat dot com
>>>>> "Ian" == Ian Lance Taylor <iant@google.com> writes:
Ian> So, I committed this patch to let -frepo look for single quotes.
Ian> /* Then try "double quotes". */
Ian> else if (p = strchr (oldq, '"'), p)
Ian> p++, q = strchr (p, '"');
Ian> + /* Then try "single quotes". */
Ian> + else if (p = strchr (oldq, '\''), p)
Ian> + p++, q = strchr (p, '\'');
Here's a small nit for you -- I think the style in the comments here
is supposed to reflect the style of the matched text... hence:
/* First try `GNU style'. */
/* Then try "double quotes". */
So I think this ought to read /* Then try 'single quotes'. */
I think this detail is so small and obscure that I should qualify for
a prize.
Tom