This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
PATCH COMMITTED: Let -frepo look for symbol name in single quotes
- From: Ian Lance Taylor <iant at google dot com>
- To: gcc-patches at gcc dot gnu dot org
- Date: Mon, 31 Mar 2008 11:04:23 -0700
- Subject: PATCH COMMITTED: Let -frepo look for symbol name in single quotes
gold outputs undefined symbol names in single quotes:
ld: hello.o: in function main:hello.c:5: undefined reference to 'puts'
This differs from GNU ld, which use mismatched quotes:
hello.c:5: undefined reference to `puts'
Currently collect2 when using -frepo looks at linker error messages
for mismatched quotes, and looks for double quotes, but does not look
for single quotes. I think single quotes are an appropriate choice,
especially since that is what gcc itself uses.
So, I committed this patch to let -frepo look for single quotes.
Tested with a bootstrap and testsuite run on i686-pc-linux-gnu, both
with and without gold.
Ian
2008-03-31 Ian Lance Taylor <iant@google.com>
* tlink.c (scan_linker_output): Look for symbol name in single
quotes.
Index: tlink.c
===================================================================
--- tlink.c (revision 133761)
+++ tlink.c (working copy)
@@ -683,6 +683,9 @@ scan_linker_output (const char *fname)
/* Then try "double quotes". */
else if (p = strchr (oldq, '"'), p)
p++, q = strchr (p, '"');
+ /* Then try "single quotes". */
+ else if (p = strchr (oldq, '\''), p)
+ p++, q = strchr (p, '\'');
else {
/* Then try entire line. */
q = strchr (oldq, 0);