This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix PR34916, 35519 Combine (Dataflow merge regression.)

On Tue, Mar 25, 2008 at 08:30:32AM -0400, hutchinsonandy@aim.com wrote:
> --- combine.c	(revision 133510)
> +++ combine.c	(working copy)
> @@ -976,8 +976,17 @@
>                       assignments later.  */
>                    if (regno >= FIRST_PSEUDO_REGISTER
>                        || asm_noperands (PATTERN (use_insn)) < 0)
> -                    LOG_LINKS (use_insn) =
> -                      alloc_INSN_LIST (insn, LOG_LINKS (use_insn));
> +		    {
> +		      /* Don't add duplicate links between instructions.  */
> +		      rtx links;
> +		      for (links = LOG_LINKS (use_insn); links; links = XEXP (links, 1))

This line is too long (89 chars), put links = XEXP (links, 1)) on a separate line.

> @@ -13056,3 +13065,5 @@
>   }
>  };
>  
> +
> +

And this is completely unnecessary and unrelated change.

	Jakub
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]