This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c
On Wed, Mar 19, 2008 at 9:43 PM, Kai Tietz <Kai.Tietz@onevision.com> wrote:
> "Danny Smith" <dansmister@gmail.com> wrote on 19.03.2008 07:01:25:
>
> > Actually., I think it makes a lot of sense to test whether the
> > appropriate warning is reported.
> I agree, that some testcases have to be added to test all ms versus gnu
> feature set. When the initial patch is applied, we can add the additional
> necessary testcases. Eg. the test for 'll', additional tests for 'I64',
> 'I32', and 'I' in failure cases (ISO C, wrong type specifiers, etc). For
> this patch I wanted just to have an initial set of major tests, where
> others can continue on.
>
>
> > Also, if you look again at the msdn page you will note that the field
> > width flag (a glibc extensuion) is not documented.
> > Indeed if you test a format like "%5m", you will see that it produces
> > this as output: "m" The use of this flag should produce a warning.
> You are right, I removed the 'w' flag for ms_strftime.
>
Hello Kai
Thank you for your perseverence, Kai. The mingw32-specific changes in
the latest patchset are OK for trunk
Danny
> Cheers,
> Kai
>
>
>
> PS: NightStrike could you rerun the testsuite? Thanks in advance.
>
>
>
> | (\_/) This is Bunny. Copy and paste Bunny
> | (='.'=) into your signature to help him gain
> | (")_(") world domination.
>