This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] contrib/patch_tester.sh, 4 of 7
- From: "Sebastian Pop" <sebpop at gmail dot com>
- To: janis187 at us dot ibm dot com
- Cc: gcc-patches at gcc dot gnu dot org, tromey at redhat dot com
- Date: Fri, 7 Mar 2008 11:54:53 -0600
- Subject: Re: [PATCH] contrib/patch_tester.sh, 4 of 7
- References: <1204761289.6363.33.camel@janis-laptop>
On Wed, Mar 5, 2008 at 5:54 PM, Janis Johnson <janis187@us.ibm.com> wrote:
> This patch to contrib/patch_tester.sh causes options specified for
> configure, make, and make check to be evaluated, allowing them to
> include environment variables that can be different on different
> machines (including different targets) on which the patch is tested.
> It also adds more information to a failure message, and uses "make"
> instead of "make bootstrap" allowing simple builds with
> "disable-bootstrap" for preliminary test runs.
>
> The "eval" changes are probably not needed with Tom's change to pick
> up local options from a file, but might still be useful.
>
> Sebastian, OK for trunk?
>
Yes, thanks.
> --- patch_tester.sh.3 2008-03-05 15:29:28.000000000 -0800
> +++ patch_tester.sh 2008-03-05 15:29:31.000000000 -0800
> @@ -301,14 +301,15 @@ bootntest () {
> cd $BUILD
>
> CONFIG_OPTIONS=`grep "^configure:" $PATCH | sed -e "s/^configure://g"`
> - if ! $SOURCE/configure $CONFIG_OPTIONS &> $1/configure ; then
> - report "configure failed with:"
> + if ! eval $SOURCE/configure $CONFIG_OPTIONS &> $1/configure ; then
> + report "configure with `basename $1` version failed with:"
> freport $1/configure
> return 1
> fi
>
> - if ! make $dashj `grep "^make:" $PATCH | sed -e "s/^make://g"` bootstrap &> $1/bootstrap ; then
> - report "bootstrap failed with last lines:"
> + if ! eval make $dashj `grep "^make:" $PATCH \
> + | sed -e "s/^make://g"` &> $1/bootstrap ; then
> + report "bootstrap with `basename $1` version failed with last lines:"
> tail -30 $1/bootstrap > $1/last_bootstrap
> freport $1/last_bootstrap
> report "grep --context=20 Error bootstrap:"
> @@ -318,7 +319,7 @@ bootntest () {
> fi
>
> CHECK_OPTIONS=`grep "^check:" $PATCH | sed -e "s/^check://g"`
> - make $dashj $CHECK_OPTIONS -k check &> $1/check
> + eval make $dashj $CHECK_OPTIONS -k check &> $1/check
>
> for LOG in $TESTLOGS ; do
> if [ -f $BUILD/$LOG ]; then
>
>
>
--
Sebastian
AMD - GNU Tools