Re: [PATCH] contrib/patch_tester.sh, 6 of 7

["Sebastian Pop" <sebpop at gmail dot com>]

On Thu, Mar 6, 2008 at 8:00 AM, Tom Tromey <tromey@redhat.com> wrote:
> >>>>> "Janis" == Janis Johnson <janis187@us.ibm.com> writes:
>
>  Janis> This patch to contrib/patch_tester.sh makes it work for patches that
>  Janis> do not include any changes under gcc/.  There could well be a better
>  Janis> way to do this than just requiring patches to be made at the top level.

The patch looks good.

>
>  FWIW I think it is fine to require this.
>  Perhaps it needs to be documented somewhere.
>

Why not documenting this requirement in the fail message:
something like this...

   if ! patch -p0 < $PATCH &> $TESTING/patching ; then
       report "your patch failed to apply:"
       report "remember that testing patches should be taken at the
top level and not in subdirectories."

Thanks for your improvements,
Sebastian
-- 
AMD - GNU Tools