This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [tuples] [patch] refactoring of tree_expr_nonzero_warnv_p

From: Diego Novillo <dnovillo at google dot com>
To: Rafael Espindola <espindola at google dot com>
Cc: Richard Guenther <richard dot guenther at gmail dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 04 Mar 2008 07:54:06 -0500
Subject: Re: [tuples] [patch] refactoring of tree_expr_nonzero_warnv_p
References: <38a0d8450803040209gf52e35fh1f4d76fd5202d1bd@mail.gmail.com> <84fc9c000803040238m21e01f75s2da56a4a2f8c4441@mail.gmail.com> <38a0d8450803040303l18f78b93h9b49aba97a142fbb@mail.gmail.com>

On 3/4/08 6:03 AM, Rafael Espindola wrote:

+   If the return value is based on the assumption that signed overflow
+   is undefined, set *STRICT_OVERFLOW_P to true; otherwise, don't
+   change *STRICT_OVERFLOW_P.  */
+static bool

Blank line after comment.

+tree_binary_nonzero_warnv_p (enum tree_code code,
+				  tree type __attribute__((unused)),

ATTRIBUTE_UNUSED. But if it's not used, don't add it.

OK for trunk and branch with a ChangeLog entry and testing (BTW, please always include ChangeLog entries with your patches).

Diego.

References:
- [tuples] [patch] refactoring of tree_expr_nonzero_warnv_p
  - From: Rafael Espindola
- Re: [tuples] [patch] refactoring of tree_expr_nonzero_warnv_p
  - From: Richard Guenther
- Re: [tuples] [patch] refactoring of tree_expr_nonzero_warnv_p
  - From: Rafael Espindola

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]