This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch ping
- From: Tom Tromey <tromey at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Wed, 20 Feb 2008 07:59:07 -0700
- Subject: Re: Patch ping
- References: <20080220133526.GM24887@devserv.devel.redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Jakub> Preprocessing fix for macro expanded #pragmas:
Jakub> http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01145.html
Jakub> Bootstrapped/regtested many times on many linux targets, ok for 4.4?
I don't think I can approve or reject this patch, since it is part of
the C FE and not libcpp.
That said, it looks pretty reasonable to me. It seems a bit odd to
duplicate the pragma/name mapping in c_pp_lookup_pragma and in
init_pragma. I think it would be mildly better to keep this
information in a single place.
Tom