Re: PR/32009, separate BOOT_CFLAGS and BOOT_LIBCFLAGS

[Paolo Bonzini <bonzini at gnu dot org>]

> Index: Makefile.tpl
> ===================================================================
> --- Makefile.tpl        (revision 131960)
> +++ Makefile.tpl        (working copy)
> @@ -278,6 +278,7 @@ BUILD_PREFIX_1 = @BUILD_PREFIX_1@
>  # Flags to pass to stage2 and later makes.  They are defined
>  # here so that they can be overridden by Makefile fragments.
>  BOOT_CFLAGS= -g -O2
> +BOOT_LIBCFLAGS= -g -O2 -fbooh-not-pic

Uhm, no ;-)  That was the option I was talking about...  I gave it a 
ridiculous name so that people would spot it at once if I screwed up -- 
which happened indeed.  Of course, I had to remove it before starting 
the bootstrap/regtest on a tree which did not have -fbooh-not-pic.

> I'd also like to know what effect your change has for cross
> builds.

The main effect is that overriding CFLAGS_FOR_TARGET on the commandline 
will *not* disable sysroot and debug-prefix flags.

> I know I was a bit surprised way back to see that
> MULTILIB_EXTRA_OPTS isn't (wasn't) applied to libraries for the
> base multilib (other than libgcc) and I was on a lookout for a
> replacement (a CFLAGS used for libraries built at gcc build
> time); this sounds like the way.

There was always CFLAGS_FOR_TARGET but it had the problem of needing 
adjustments in the case of sysroot builds.  This patch should fix that 
problem.

Paolo