This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [h8300] misc patches
- From: Jeff Law <law at redhat dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Feb 2008 12:23:23 -0700
- Subject: Re: [h8300] misc patches
- References: <200801212310.m0LNAejt030049@greed.delorie.com> <20080122172809.W64890@dair.pair.com> <200802191432.m1JEWi1p016403@greed.delorie.com>
DJ Delorie wrote:
Now that we've missed the cutoff for getting a working H8/300 port
in 4.3, can we revisit these patches?
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg00973.html
http://gcc.gnu.org/ml/gcc-patches/2008-01/msg01122.html
The hunk to change emit_insn to emit_jump_insn is obviously correct.
It wouldn't be a terrible idea to do a grep across all the backends
for this buglet -- I know I've fixed the exact same problem once or
twice in other ports.
My H8 is very rusty, but I don't think the target supports anything
except a register for that operand. So I think we're better off
tightening the expander rather than loosening the matching pattern.
It looks like one variant of the patch does that. Assuming it's
passed testing, I'm good with it.
jeff