Re: [PATCH]: fixincludes hack for solaris11 c99-math testsuite failures

[Mark Mitchell <mark at codesourcery dot com>]

Kaveh R. GHAZI wrote:

> but in summary, on solaris2.11 sun's definition of isinf() is not
> FP-exception safe in the presence of NaN.  So I wrote a fix-hack that
> instead points the macro at GCC's __builtin_isinf() which is safe.  Prior
> versions of solaris don't have the problem because they don't use the
> bogus macro definition.
c
> 2008-02-17  Kaveh R. Ghazi  <ghazi@caip.rutgers.edu>
>
> 	* inclhack.def (solaris_math_10): New.
> 	* tests/base/iso/math_c99.h: Update.
>
> 	* fixincl.x: Regenerate.

I don't think it's a good idea to limit the fix to Solaris 11.  It's 
desirable to make a Solaris 10 compiler binary package work on Solaris 
11, if you rerun the fixincludes bits.  That's why we package that with 
the installed compiler -- we want people to be able to rerun.

So, if we want to fixinclude this, we should do something that detects 
at the point of running fixincludes, not based on the target configuration.

But isn't this just a Solaris run-time library defect?  Presumably if 
you build the same code with Sun's compiler, you'd have the same bug. 
It's not our job to work around these sorts of defects.  So, I think we 
should XFAIL the tests and move on.

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713