This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Re: Mainline Regression in gcc.target/i386/pr32268.c
On Sun, Feb 17, 2008 at 08:27:03AM +0100, Uros Bizjak wrote:
> Jakub Jelinek wrote:
>
> >>Please don't. The fix is to change soft-float/soft-fp.h a bit. Jakub, is
> >>this change acceptable for glibc?
> >>
> >
> >No. You should IMHO instead
> >#define CMPtype int __attribute__ ((mode (__libgcc_cmp_return__)))
> >in config/i386/sfp-machine.h.
> >There is nothing libc specific on having a default CMPtype definition.
> >
>
> Hm, this won't fly.
Ok, you're right. Should have tried that in fn return value :(
> But following will:
>
> typedef int __gcc_CMPtype __attribute__ ((mode (__libgcc_cmp_return__)));
> #define CMPtype __gcc_CMPtype
So would:
typedef int CMPtype __attribute__ ((mode (__libgcc_cmp_return__)));
#define CMPtype CMPtype
> Attached patch adds this construct to i386/sfp-machine.h and
> rs6000/sfp-machine.h. It also changes test as Kaveh suggested.
Do we really need to change rs6000 before 4.3 release? AFAIK soft-fp
is used there just for 32-bit stuff, and __libgcc_cmp_return__ will be there
always int. All I'm saying is that in rs6000 case this isn't a regression
bugfix of any kind (and I doubt
http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=132350
has been a regression bugfix either). I'd say that's just a cleanup
we can do once 4.4 reopens (Monday).
Jakub