This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Why is testsuite/27_io/fpos/14320-1.cc XFAILed everywhere?
- From: Paolo Carlini <pcarlini at suse dot de>
- To: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 14 Feb 2008 13:16:14 +0100
- Subject: Re: Why is testsuite/27_io/fpos/14320-1.cc XFAILed everywhere?
- References: <Pine.GSO.4.58.0802130141290.23966@caipclassic.rutgers.edu>
Hi Kaveh,
> The testcase 27_io/fpos/14320-1.cc has:
>
> // { dg-do run { xfail *-*-* } }
>
> but I'm seeing XPASS on LP64 targets. It looks like it's trying to match
> typeids for a type that is 64 bits. It checks vs long and smaller types
> and so lp64 works, but ilp32 doesn't.
>
> I think I can fix this by either changing the xfail to "! lp64" or adding
> a "long long" clause to the typeid checks so that ilp32 targets work too.
This test is becoming more and more obsolete. It dates back to when the
C++ Standard didn't have long long, thus a streamoff, being a signed
integer type, could not be a long long. All of this is already fixed for
C++0x and really people are already using long long in C++ everywhere,
these days.
Therefore, I think we should just add a long long clause, + a comment
mentioning the above issue, and be done with it. If you can prepare and
test a patch, consider it pre-approved.
Thanks,
Paolo.