This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Committed] S/390: Fix 20020926-1.c testcase on s390x
- From: Janis Johnson <janis187 at us dot ibm dot com>
- To: Andreas Krebbel <Andreas dot Krebbel at de dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 22 Jan 2008 13:05:47 -0800
- Subject: Re: [Committed] S/390: Fix 20020926-1.c testcase on s390x
- References: <20080122131321.GA10600@homer.boeblingen.de.ibm.com>
- Reply-to: janis187 at us dot ibm dot com
On Tue, 2008-01-22 at 14:13 +0100, Andreas Krebbel wrote:
> Hi,
>
> when the s390 testsuite directory was created the target requirements
> were removed. That made the 20020926-1.c testcase to be executed also
> on s390x where -m64 is the default. This does not go together with
> -mesa.
>
> I've committed the attached patch after checking that it makes the
> testcase working on 64 bit.
> /* { dg-do compile } */
> ! /* { dg-options "-O2 -m31 -mesa" } */
Tests should not use options like -m31 directly, because for
targets that support multilibs the tests should be run each
way. Instead, skip the test if it isn't relevant for the
mode currently being tested. In this case I assume that
would be
/* { dg-do compile { target { ! lp64 } } } */
Janis