This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR33092: [4.3 Regression] Using -O1 -fno-tree-salias results in ICE


On Jan 18, 2008 1:27 PM, Manuel López-Ibáñez <lopezibanez@gmail.com> wrote:
> On 18/01/2008, Richard Guenther <richard.guenther@gmail.com> wrote:
> >
> > Can you instead of the fancy gate simply make that alias pass unconditional
> > and return 0 from create_structure_vars instead of TODO_rebuild_alias?
> >
>
> That will change the output of dumping the salias pass
> (create_structure_vars). I tried. I could update the broken tests
> (around 8), but I think it isn't worth it. Probably some people rely
> on the output of salias to stay as it is.
>
> But it is your call, not mine.

Hm, yeah.  Danny changed the testcases to look in salias.

Your original patch is ok then.  Did you check whether -fno-tree-salias
results in a working compiler, that is, we don't start miscompiling random
functions?  (I know I was arguing to simply remove the -ftree-salias option)

Thanks,
Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]