This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix for automatic parallelization
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Sebastian Pop <sebpop at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Zdenek Dvorak <rakdver at kam dot mff dot cuni dot cz>, Richard Guenther <richard dot guenther at gmail dot com>
- Date: Wed, 16 Jan 2008 18:35:05 -0500 (EST)
- Subject: Re: [patch] Fix for automatic parallelization
- References: <cb9d34b20801091700v71544c56uf038126ff0114487@mail.gmail.com>
On Wed, 9 Jan 2008, Sebastian Pop wrote:
> For compiling the SPEC Cpu2006 with -ftree-parallelize-loops=4, I'm
> using the attached patch. Without this patch no program is able to
> properly compile with autopar. There still are some bugs left after
> this patch, i.e. in lambda_transform_legal_p at lambda-code.c:2595,
> that I will fix later on. For keeping the patches smaller, okay for
> trunk after regstrap?
This patch has the effect of adding -pthread (regardless of
support) whenever -ftree-parallelize-loops=* is passed.
Is that really intended? Hm, looking at the documentation,
perhaps. If so, please fix the test-suite - and IMHO the
documentation (it doesn't explicitly say "not supported for all
targets" / "where supported, implies -pthread" which can
actually be an important detail and otherwise missed).
(You might want to add an effective target "pthread" if you
don't want to list *-linux* et al in the target specifier.)
See PR driver/34821.
brgds, H-P