This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [C++ PATCH] Fix parameter packs with default arguments (PR c++/34751)

From: Jason Merrill <jason at redhat dot com>
To: Doug Gregor <doug dot gregor at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Tue, 15 Jan 2008 11:43:21 -0500
Subject: Re: [C++ PATCH] Fix parameter packs with default arguments (PR c++/34751)
References: <24b520d20801141401n730a90fbm8cc206111b7a765b@mail.gmail.com>

+ /* Consume the `...'. */

The second of these should be "the '='".

+	  /* Make sure that PARSER->GREATER_THAN_IS_OPERATOR_P is
+	     set correctly.  */

>[...]

Looks like you copied this code from cp_parser_parameter_declaration; please break it out into a separate function instead.

Jason

Follow-Ups:
- Re: [C++ PATCH] Fix parameter packs with default arguments (PR c++/34751)
  - From: Doug Gregor

References:
- [C++ PATCH] Fix parameter packs with default arguments (PR c++/34751)
  - From: Doug Gregor

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]