This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR middle-end/31309

From: "Richard Guenther" <richard dot guenther at gmail dot com>
To: "Eric Botcazou" <ebotcazou at adacore dot com>
Cc: "Ian Lance Taylor" <iant at google dot com>, gcc-patches at gcc dot gnu dot org, "Richard Kenner" <kenner at vlsi1 dot ultra dot nyu dot edu>
Date: Sun, 13 Jan 2008 17:26:41 +0100
Subject: Re: [PATCH] Fix PR middle-end/31309
References: <200801102347.18797.ebotcazou@adacore.com> <200801111814.29984.ebotcazou@adacore.com> <m3fxx46wcf.fsf@localhost.localdomain> <200801112018.04452.ebotcazou@adacore.com>

On Jan 11, 2008 8:18 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
> > If I'm going to approve the patch, I'm going to insist that
> > assignments within conditional expressions be the exception to avoid
> > lots of duplication, not the rule.  For long term maintainability,
> > code readability is the highest priority.  It's not the only priority,
> > but it's the highest.
>
> I personally don't find my version less readable than yours, but I guess I'm
> too used to the GCC style.  I'm going to install your version, thanks.

The new testcase segfaults for me on x86_64-unknown-linux-gnu.  Maybe
the math needs adjustment for different pointer-size / alignment on
64bit targets?

Richard.

Follow-Ups:
- Re: [PATCH] Fix PR middle-end/31309
  - From: Eric Botcazou

References:
- [PATCH] Fix PR middle-end/31309
  - From: Eric Botcazou
- Re: [PATCH] Fix PR middle-end/31309
  - From: Eric Botcazou
- Re: [PATCH] Fix PR middle-end/31309
  - From: Ian Lance Taylor
- Re: [PATCH] Fix PR middle-end/31309
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]