This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC

From: "Kaveh R. Ghazi" <ghazi at caip dot rutgers dot edu>
To: "Diego Novillo" <dnovillo at google dot com>
Cc: <gcc-patches at gcc dot gnu dot org>, <janis187 at us dot ibm dot com>
Date: Fri, 11 Jan 2008 09:03:19 -0700
Subject: Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
References: <Pine.GSO.4.58.0801110020440.2714@caipclassic.rutgers.edu> <b798aad50801110647k4566b256l1b0aa77d2d8bcdb3@mail.gmail.com>

From: "Diego Novillo" <dnovillo@google.com> Subject: Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC

Coming back to your patch, it won't make a difference.  The test is
still wrong.  I'm surprised that it breaks with -fpic, why is that?

Wild guess: If the testcase should be failing and inlining is causing the failure to be hidden, then when using -fpic or -fPIC the compiler can no longer assume the calls bind locally and decides not to inline.

So then when I add static, then it inlines even with -fpic/-fPIC and resumes hiding the bug again.

       --Kaveh
--
Kaveh R. Ghazi

Follow-Ups:
- Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
  - From: Diego Novillo

References:
- [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
  - From: Kaveh R. GHAZI
- Re: [PATCH]: testsuite fix for gcc.dg/tree-ssa/20070302-1.c with -fpic/-fPIC
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]