This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR 34472: Fix use-after-free() and VEC iteration bugs in ipa-struct-reorg
- From: Richard Sandiford <rsandifo at nildram dot co dot uk>
- To: Olga Golovanevsky <OLGA at il dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org, olga at gcc dot gnu dot org, dave at hiauly1 dot hia dot nrc dot ca
- Date: Thu, 10 Jan 2008 18:16:24 +0000
- Subject: Re: PR 34472: Fix use-after-free() and VEC iteration bugs in ipa-struct-reorg
- References: <OF85D4C4DF.06B574CB-ONC22573CC.004C7491-C22573CC.0053A910@il.ibm.com>
Olga Golovanevsky <OLGA@il.ibm.com> writes:
> Richard Sandiford <rsandifo@nildram.co.uk> wrote on 10/01/2008 15:25:55:
>> This patch is a fix for PR34472 (but was actually posted to the
>> related PR34483). ipa-struct-reorg.c is freeing a htab from inside a
>> htab_traverse of it. Also, a couple of "remove this structure?" loops
>> were skipping the structure that replaces a removed one.
>>
>> There is an alternative fix attached to PR34472 itself, but I prefer
>> this one, because it doesn't involve allocating extra memory for a
>> pending free list.
>>
>> The PR is about existing testsuite FAILs that only show up on some
>> host/target combinations.
>>
>> Bootstrapped & regression-tested on x86_64-linux-gnu.
>> Also regression-tested on mips64-linux-gnu. OK to install?
>
> Richard,
>
> Your patch (suggested for PR 34483), also as mine patch (suggested for
> PR 34472), is not actually final solution for the problem. While
> closing the ICE, it produced execution failures reported in the PR
> 34483 that is not solved yet. Also with your patch there are 2
> failures reported by Dave.
Oh, perhaps I misunderstood Dave's comment. Dave: can you confirm
that the patch introduced failures that weren't there previously?
Richard