This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix PR34017: ICE in lambda_loopnest_to_gcc_loopnest

From: "Sebastian Pop" <sebpop at gmail dot com>
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: "Daniel Berlin" <dberlin at dberlin dot org>, "GCC Patches" <gcc-patches at gcc dot gnu dot org>
Date: Wed, 9 Jan 2008 09:06:28 -0600
Subject: Re: [patch] Fix PR34017: ICE in lambda_loopnest_to_gcc_loopnest
References: <cb9d34b20801082217k3c344f17l2c87ae4360320c33@mail.gmail.com> <84fc9c000801090157v75d7bc0dydb1eefb1571339bc@mail.gmail.com>

On Jan 9, 2008 3:57 AM, Richard Guenther <richard.guenther@gmail.com> wrote:
>
> This looks good, though the two functions share lots of things and their
> interface is not exactly clear (the documentation doesn't mention any
> of the params).  Maybe folding them back into their caller makes the
> control flow easier to read.
>

Right, in this case separating into subfunctions is not going to bring
things simpler.  I'll put that code back in the same function and just
special case the insertion of stmts on edges for PHI_NODEs.

-- 
Sebastian
AMD - GNU Tools

Follow-Ups:
- Re: [patch] Fix PR34017: ICE in lambda_loopnest_to_gcc_loopnest
  - From: Sebastian Pop

References:
- [patch] Fix PR34017: ICE in lambda_loopnest_to_gcc_loopnest
  - From: Sebastian Pop
- Re: [patch] Fix PR34017: ICE in lambda_loopnest_to_gcc_loopnest
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]