This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR tree-optimization/34708 (too much inlining)
On Tue, Jan 08, 2008 at 01:54:24PM +0100, Jan Hubicka wrote:
> Hmm, good point. I am testing patch with removing switch_cost
> completely and will commit it if passes. It still match on the
> testcase. Naturally removing comple of cases to get overall cost down
> I can still get the function inlined, question is whether on real
> application the testcase is comming from we would still blow the limited
> PLT table.
It wasn't PLT that overflowed, but .toc1 (which must be <= 64KB on ppc64)
and each of the > 3000 inlined copies of that function ate 8 bytes in .toc1,
which together with the excessive amount of needed string literals blew
.toc1 out.
> We still would have less chances for that due to limiting cascaded
> inlining (ie for function calling ErrorType it is now harder to remain
> small function).
I've attached the original preprocessed source to the PR,
so that you can play with it yourself.
Jakub