This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Add __GXX_RTTI for libstdc++/34680
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Paolo Carlini <pcarlini at suse dot de>
- Cc: Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 06 Jan 2008 12:48:39 -0800
- Subject: Re: [Patch] Add __GXX_RTTI for libstdc++/34680
- References: <4780C4C7.7020802@suse.de>
Paolo Carlini wrote:
> this simple patch adds a predefined macro which will be used to fix in
> mainline libstdc++/34680.
>
> Tested x86_64-linux. Ok?
> gcc/
> 2008-01-06 Paolo Carlini <pcarlini@suse.de>
>
> PR libstdc++/34680
> * c-cppbuiltin.c (c_cpp_builtins): Define __GXX_RTTI, if appropriate.
> * doc/cpp.texi ([Common Predefined Macros]): Document.
This is, per se, a new feature, so we could wait for 4.4 -- but let's
not, given that you have a bug that this will help fix in the runtime.
Sandra Loosemore has been teaching us CodeSourcery folks that technical
documentation should be written in the present tense, so I guess this
would be better as:
> + @item __GXX_RTTI
> + This macro is defined, with value 1, when compiling a C++ source file
> + with runtime type identification enabled. If @option{-fno-rtti} was
s|was|is
> + used when compiling the file, then this macro will not be defined.
s|will not|is not
Also, I think that "runtime" is better spelled as "run-time", though I
see that our current documentation has both spellings, so that's up to you.
OK with those nit-picks. :-)
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713