This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Ping - old patch from April - mingw support for I32/I64 MS printf formatters to c-format.c


On Thu, 20 Dec 2007, Kai Tietz wrote:

> I moved the test case to gcc.dg/format as mentioned. No until now I didn't 
> ran all test-case for this. But I am certain, we need to re-arrange things 
> here.

I will await a patch with such rearrangements, confirmed to pass all tests 
on both MinGW and non-MinGW, and with new tests added to test that all the 
standard and GNU features not supported by Windows receive proper 
diagnostics (for example, a test that %ll gets a diagnostic on Windows), 
before attempting any detailed review.

I also await the answer to my question:

Does the set of format features supported on Windows depend at all on the 
version of Windows?  If so, for what version of Windows did you prepare 
the tables of supported features?

Were the tables prepared by examining Windows documentation, or by running 
tests on Windows?  Either would be OK, but one or the other must have been 
done for every feature and combination in the tables you have of Windows 
formats, and for verifying that the C99 features removed as not supported 
on Windows are indeed not supported.

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]