[Ada] PR ada/15803 & 15805

[Arnaud Charlet <charlet at adacore dot com>]

Tested on i686-linux, committed on trunk.

This patch is a follow-up of changes made by Sam in the context of
PR ada/15803 (well actually there was apparently some confusion/typo,
so the PR ref seems to be wrong here), where we improve the patch/message.

This patch is also a follow up of Sam's changes for PR ada/15805, where
we also improve the previous patch and error message.

Also fix ACATS B371001 at the same time.

2007-12-19  Ed Schonberg  <schonberg@adacore.com>
	    Gary Dismukes  <dismukes@adacore.com>

	PR ada/15803, ada/15805
	* sem_ch6.adb, sem_ch3.adb (Constrain_Access): In Ada2005, diagnose
	illegal access subtypes when there is a constrained partial view.
	(Check_For_Premature_Usage): New procedure inside
	Access_Subprogram_Declaration for checking that an access-to-subprogram
	type doesn't reference its own name within any formal parameters or
	result type (including within nested anonymous access types).
	(Access_Subprogram_Declaration): Add call to Check_For_Premature_Usage.
	(Sem_Ch3.Analyze_Object_Declaration, Sem_ch6.Process_Formals): if the
	context is an access_to_variable, the expression cannot be an
	access_to_constant.

Attachment: difs
Description: Text document