This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] PR32901: handle assignment...(and PR34465 and PR34448)

From: Aldy Hernandez <aldyh at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: Diego Novillo <dnovillo at google dot com>, gcc-patches at gcc dot gnu dot org, mark at codesourcery dot com
Date: Mon, 17 Dec 2007 12:18:33 -0400
Subject: Re: [patch] PR32901: handle assignment...(and PR34465 and PR34448)
References: <20071211192218.GA23758@redhat.com> <20071211231544.GA25459@redhat.com> <475F3B31.30000@google.com> <20071212143820.GS20451@devserv.devel.redhat.com> <20071214212527.GA13781@redhat.com> <20071217152655.GN20451@devserv.devel.redhat.com>

> It looks good to me (though you need to find someone^H^H^H^H^H^H^HDiego to
> approve it anyway), except that the unshare_expr is IMHO done too early,
> wasting GC memory if gimplify_init_constructor returns GS_ERROR.  I believe

Good catch!  Fixed.

Diego, how does the patch look?

Aldy

References:
- [patch] PR32901: handle assignment from constructors better
  - From: Aldy Hernandez
- Re: [patch] PR32901: handle assignment from constructors better
  - From: Aldy Hernandez
- Re: [patch] PR32901: handle assignment from constructors better
  - From: Diego Novillo
- Re: [patch] PR32901: handle assignment from constructors better
  - From: Jakub Jelinek
- Re: [patch] PR32901: handle assignment...(and PR34465 and PR34448)
  - From: Aldy Hernandez
- Re: [patch] PR32901: handle assignment...(and PR34465 and PR34448)
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]