This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[PATCH, committed] Cleanup warning/error buffer target selection in light of -Werror
- From: Bernhard Fischer <rep dot dot dot nop at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: fortran at gcc dot gnu dot org
- Date: Sun, 16 Dec 2007 20:30:06 +0100
- Subject: [PATCH, committed] Cleanup warning/error buffer target selection in light of -Werror
Hi,
Fixing a mishap from the early days of PR21061 was lying around locally:
Irresponsible of -Werror, warnings still are to go straight to the
warning buffer -- diagnostics will TDRT anyway. So i'm (un)installing this
hunk that should not have been installed in the first place.
My initial (misguided) thought was that if -Werror, then warnings should
go straight to the error-buffer which is of course not the right thing
to do. Note that in effect the erroneous hunk corrected below did never
have a negative side-effect.
This erroneous hunk was thus reverted as r130990 to again read like it did
originally:
Index: gcc-4.3/gcc/fortran/error.c
===================================================================
--- gcc-4.3/gcc/fortran/error.c (revision 130960)
+++ gcc-4.3/gcc/fortran/error.c (working copy)
@@ -715,8 +715,7 @@ gfc_notify_std (int std, const char *noc
if (gfc_suppress_error)
return warning ? SUCCESS : FAILURE;
- cur_error_buffer = (warning && !warnings_are_errors)
- ? &warning_buffer : &error_buffer;
+ cur_error_buffer = warning ? &warning_buffer : &error_buffer;
cur_error_buffer->flag = 1;
cur_error_buffer->index = 0;