This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: libcpp/charset: close out shift states

From: Tom Tromey <tromey at redhat dot com>
To: DJ Delorie <dj at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Tue, 11 Dec 2007 09:13:08 -0700
Subject: Re: libcpp/charset: close out shift states
References: <200712062019.lB6KJqeE001748@greed.delorie.com> <m3y7c21k66.fsf@fleche.redhat.com> <200712102118.lBALIEFo004155@greed.delorie.com>
Reply-to: tromey at redhat dot com

>>>>> "DJ" == DJ Delorie <dj@redhat.com> writes:

DJ> How about this?  I pulled some common code out into a macro, because I
DJ> didn't know how portable it would be to call iconv with inbytesleft==0

Looks good to me, thanks.

If you want to address Mike Meissner's point, that is also fine by me.
IMO it doesn't matter hugely for local macros like this one, but a
little extra defense doesn't hurt.

Tom

Follow-Ups:
- Re: libcpp/charset: close out shift states
  - From: DJ Delorie

References:
- libcpp/charset: close out shift states
  - From: DJ Delorie
- Re: libcpp/charset: close out shift states
  - From: Tom Tromey
- Re: libcpp/charset: close out shift states
  - From: DJ Delorie

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]