This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libstdc++] Fix some header warnings


> CXXFLAGS vs. libstdc++ make check.

Yes. This is to accommodate the C++0x and parallel mode testing,
although it's been useful for a lot of other stuff. (atomics, debug,
-fno-exeptions.) Before this, we had to hand-edit testsuite_flags.in.

It's been this way since the beginning of August.

If this surprises you, and you think this should be done differently,
I'd like to hear more.

> Ok, will wait for Benjamin to comment on this ;)

The original code was wrong: what was checked in was "as if" s was a
basic_ostringstream, not std::string. (Original code was
std::ostringstream: I was trying to slimline deps.). Thus the use of
operator +=.

There are no std::string operator += (int). So, what is printed when
this was used was not correct. Thus, the change.

I think your change looks fine Jakub (and Paolo). Thanks to both of you
for cleaning this stuff up.


best,
benjamin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]